コミットメタ情報

リビジョン866348fee598452e32462df058ad0a241266083d (tree)
日時2014-11-26 02:45:23
作者henoheno <henoheno>
コミッターumorigu

ログメッセージ

BugTrack2/236: "===" for two numerical strings. Can't rename "1" to "01".

変更サマリ

差分

--- a/plugin/rename.inc.php
+++ b/plugin/rename.inc.php
@@ -39,16 +39,16 @@ function plugin_rename_action()
3939 $page = plugin_rename_getvar('page');
4040 $refer = plugin_rename_getvar('refer');
4141
42- if ($refer == '') {
42+ if ($refer === '') {
4343 return plugin_rename_phase1();
4444
4545 } else if (! is_page($refer)) {
4646 return plugin_rename_phase1('notpage', $refer);
4747
48- } else if ($refer == $whatsnew) {
48+ } else if ($refer === $whatsnew) {
4949 return plugin_rename_phase1('norename', $refer);
5050
51- } else if ($page == '' || $page == $refer) {
51+ } else if ($page === '' || $page === $refer) {
5252 return plugin_rename_phase2();
5353
5454 } else if (! is_pagename($page)) {
@@ -394,7 +394,7 @@ function plugin_rename_getrelated($page)
394394 $pages = get_existpages();
395395 $pattern = '/(?:^|\/)' . preg_quote(strip_bracket($page), '/') . '(?:\/|$)/';
396396 foreach ($pages as $name) {
397- if ($name == $page) continue;
397+ if ($name === $page) continue;
398398 if (preg_match($pattern, $name)) $related[] = $name;
399399 }
400400 return $related;
@@ -406,9 +406,9 @@ function plugin_rename_getselecttag($page)
406406
407407 $pages = array();
408408 foreach (get_existpages() as $_page) {
409- if ($_page == $whatsnew) continue;
409+ if ($_page === $whatsnew) continue;
410410
411- $selected = ($_page == $page) ? ' selected' : '';
411+ $selected = ($_page === $page) ? ' selected' : '';
412412 $s_page = htmlsc($_page);
413413 $pages[$_page] = '<option value="' . $s_page . '"' . $selected . '>' .
414414 $s_page . '</option>';
旧リポジトリブラウザで表示